Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[W7][T08-1] Zhao JunRu #32

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[W7][T08-1] Zhao JunRu #32

wants to merge 2 commits into from

Conversation

quinnzzzzz
Copy link

User command is no longer case sensitive
UserGuide and Test file updated

@nus-se-pr-bot nus-se-pr-bot requested a review from stephlewyh March 3, 2019 08:26
RubaP
RubaP reviewed Mar 15, 2019
View reviewed changes
Copy link

@RubaP RubaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good that you have attempted to do an enhancement. But, it would be great if you can add a new command or improve an existing feature as suggested in the course website. It will help you to practice SE principles as well as to gain better coding experience.

@RubaP RubaP added the Reviewed label Mar 15, 2019
@RubaP
Copy link

RubaP commented Mar 15, 2019

Please review the comments and close the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RubaP RubaP RubaP left review comments

@stephlewyh stephlewyh Awaiting requested review from stephlewyh

Assignees

@RubaP RubaP

Labels
Reviewed team.1 tutorial.T08
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@quinnzzzzz @RubaP @nus-se-pr-bot