[W7][M11-3] Dannica Ong

[dannong]

• Displays the list of contacts after each addition of new contact
• Edit Help page for easier reading
• Updated User Guide
• Added new Unit tests
• Update existing tests

[devamanyu]

Good PR. If I remember correctly, wasn't your 2kloc PR same feature? Has there been any improvement over that feature?

Please read some minor comments that I have added and then close this PR.

[devamanyu]

Good job in testing this scenario. Try to see if other exception cases can be tested too.

[devamanyu]

Please remove unwanted code lines instead of leaving them as commented out chunks.

[dannong]

Good afternoon, My previous enhancement was adding a new "gender" feature when inputting! This time round was printing the list everytime a new contact is added. Sorry for any inconvenience and hope that clarifies! Regards, Dannica Ong

On Fri, 8 Mar 2019 at 3:24 PM, Devamanyu Hazarika ***@***.***> wrote: ***@***.**** approved this pull request. Good PR. If I remember correctly, wasn't your 2kloc PR same feature? Has there been any improvement over that feature? Please read some minor comments that I have added and then close this PR. ------------------------------ In test/java/seedu/addressbook/logic/LogicTest.java <#28 (comment)> : > - // execute command and verify result - assertCommandBehavior(helper.generateAddCommand(toBeAdded), - String.format(AddCommand.MESSAGE_SUCCESS, toBeAdded), - expectedAB, - false, - Collections.emptyList()); + // prepare address book state + helper.addToAddressBook(addressBook, false, true); + + assertCommandBehavior("list", + Command.getMessageForPersonListShownSummary(expectedList), + expectedAB, + true, + expectedList); Good job in testing this scenario. Try to see if other exception cases can be tested too. ------------------------------ In src/seedu/addressbook/commands/AddCommand.java <#28 (comment)> : > @@ -60,7 +61,9 @@ public ReadOnlyPerson getPerson() { public CommandResult execute() { try { addressBook.addPerson(toAdd); - return new CommandResult(String.format(MESSAGE_SUCCESS, toAdd)); + List<ReadOnlyPerson> allPersons = addressBook.getAllPersons().immutableListView(); + //return new CommandResult(getMessageForPersonListShownSummary(allPersons), allPersons); Please remove unwanted code lines instead of leaving them as commented out chunks. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#28 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AiGSPsszcdUxphpeR0yYURnywTej6NOiks5vUhAogaJpZM4bah9-> .

-- DANNICA ONG CHUN YUN :D

[devamanyu]

Oh great!