[W7][T09-2] Zhang Jingchen #22
Conversation
| Format: `last` | ||
|
|
||
| **** | ||
| Shows the latest command typed in. |
There was a problem hiding this comment.
Interesting enhancement! Good that you have updates the user guide. But when you provide examples in the user guide try to stick to valid examples, rather than using the terms 'something' to be more professional with you work and not to confuse the user who is reading the doc.
| @@ -456,6 +456,21 @@ public void execute_find_matchesIfAnyKeywordPresent() throws Exception { | |||
| expectedList); | |||
| } | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
Avoid unnecessary comment blocks while making a PR
| * If yes then append the lastCommand for later execution. | ||
| */ | ||
| private String checkLastCommand(String userCommandText) throws Exception { | ||
| if( userCommandText.substring(0, Math.min(userCommandText.length(), 4)).equals("last")) { |
There was a problem hiding this comment.
Avoid the magical string usage like "last". You have already defined it as a constant COMMAND_WORD. So please make use of it
| */ | ||
| private String checkLastCommand(String userCommandText) throws Exception { | ||
| if( userCommandText.substring(0, Math.min(userCommandText.length(), 4)).equals("last")) { | ||
| userCommandText = userCommandText.concat(" ").concat(lastCommand); |
There was a problem hiding this comment.
It seems this is logically wrong. if the user type "last" and the previous command is "add something", then you concatenate both here before parsing. But the parser will not understand the concatenated string as it is not a valid command. I hope this process should be carried out once you parse the command (the application realizes it is the command LAST).
| @@ -58,6 +58,12 @@ public void listCommand_parsedCorrectly() { | |||
| parseAndAssertCommandType(input, ListCommand.class); | |||
| } | |||
|
|
|||
| @Test | |||
| public void LastCommand_parsedCorrectly() { | |||
There was a problem hiding this comment.
Try to work on adding multiple test cases in the future. e.g. user type last without any last command available
Added a new command: "last" which displays the last command user typed in previously.