[W5][T11-2]Teo Xuan Wei #56
Conversation
- prints "addressbook is sorted in alphabetical order" when command is called. - DummySort is reflected in the User Guide with the full list of the remaining commands (when command "help" is entered).
|
It is nice that you update the version of the address book from 1.0 to 1.1, and put blank lines among code to enhance readability in DummySortCommand.java. |
There was a problem hiding this comment.
Hi Xuan Wei,
Good effort in updating the documentation, however you could be more accurate in describing what action does your pseudosort command perform - it only prints a sort success statement, and does not pseudo sort, nor provide any operations stubs that suggests so.
Also, you could have written an I/O or unit test for your new enhancement.
| @@ -21,9 +21,9 @@ | |||
| * Initializes the application and starts the interaction with the user. | |||
| */ | |||
| public class Main { | |||
|
|
|||
| // test commit | |||
There was a problem hiding this comment.
this comment is not relevant to the enhancement. you may wish to remove this.
|
|
||
| @Override | ||
| public CommandResult execute() { | ||
| return new CommandResult(MESSAGE_SUCCESS); |
There was a problem hiding this comment.
It would be good if you have also attempted the actual sort logic, instead of returning a print statement.
Note that you are not performing a pseudo-sort here, unlike what is written in your documentation. Only a success statement is printed.
|
|
||
| public static final String MESSAGE_SUCCESS = "Address book is sorted in alphabetical order! ^^"; | ||
|
|
||
| @Override |
There was a problem hiding this comment.
Missing header comment. All non-trivial methods should have java doc format header comments.
No description provided.