[W5][T11-1]Sam #55
Open
[W5][T11-1]Sam #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like what you did there |
|
Nice coding! I wish I can code like you! |
stephlewyh
reviewed
Feb 17, 2019
There was a problem hiding this comment.
Hi Samuel,
You have attempted an OOP enhancement via a getter method and updated the user documentation, albeit in a non-standard way.
However, you need to update your header comment for code readability. Also, you could have provided a JUnit test case for getFeedbackToUser() to verify if it returns the expected string.
Nevertheless, not bad for a first attempt!
| @@ -33,4 +33,7 @@ public CommandResult(String feedbackToUser, List<? extends ReadOnlyPerson> relev | |||
| return Optional.ofNullable(relevantPersons); | |||
| } | |||
|
|
|||
| public String getFeedbackToUser() { | |||
There was a problem hiding this comment.
Missing header comment. All non-trivial methods should have java doc format header comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encapsulated a variable