[W5][T08-1]Jeremy Wong #54
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A simple but important tool of an element that we, as software engineers, often miss out. A simple greeting can make its user feels welcome. |
RubaP
reviewed
Feb 13, 2019
| @@ -156,6 +156,11 @@ Views all details of the 1st person in the results of the `find` command. | |||
| Clears all entries from the address book. + | |||
| Format: `clear` | |||
|
|
|||
| == Saying hi : `hello` | |||
|
|
|||
There was a problem hiding this comment.
Good that you have updated the UserGuide
| @@ -75,6 +65,12 @@ public void parse_clearCommand_parsedCorrectly() { | |||
| parseAndAssertCommandType(input, ClearCommand.class); | |||
| } | |||
|
|
|||
| @Test | |||
| public void parse_helloCommand_parsedCorrectly() { | |||
There was a problem hiding this comment.
Good job for adding both I/O and JUnit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.