[W5][T11-1]Jesulayomi Kupoluyi #50
Conversation
|
Good feature to consider implementing in our project! |
There was a problem hiding this comment.
Hi Layomi,
Overall you've done well in the following:
(1) Updated user documentation
(2) Provided legitimate test cases
(3) Included exceptions to catch duplicate persons
Good job!
However, you could ensure that your import statements and header comments adhere to the NUS Java coding standards.
| package seedu.addressbook.commands; | ||
|
|
||
| import seedu.addressbook.data.exception.IllegalValueException; | ||
| import seedu.addressbook.data.person.*; |
There was a problem hiding this comment.
Imported classes should always be listed explicitly. E.g. java.util.List and not java.util.*, which does not follow NUS Java coding standards.
|
|
||
| public class AddAndList extends Command{ | ||
|
|
||
| /** |
There was a problem hiding this comment.
this comment should be placed on top of a method.
| } | ||
|
|
||
| @Override | ||
| public CommandResult execute() { |
There was a problem hiding this comment.
Missing header comment. All non-trivial methods should have java doc format header comments.
| import seedu.addressbook.data.person.Phone; | ||
| import seedu.addressbook.data.person.ReadOnlyPerson; | ||
| import seedu.addressbook.data.person.UniquePersonList; | ||
| import seedu.addressbook.data.person.*; |
There was a problem hiding this comment.
Imported classes should always be listed explicitly. E.g. java.util.List and not java.util.*, which does not follow NUS Java coding standards.
| @@ -76,6 +62,9 @@ public Command parseCommand(String userInput) { | |||
| case AddCommand.COMMAND_WORD: | |||
| return prepareAdd(arguments); | |||
|
|
|||
| case AddAndList.COMMAND_WORD: | |||
There was a problem hiding this comment.
This indentation is not consistent with the other cases. It affects the readability of your code.
No description provided.