Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[W5][T11-2]WU PEI HSUAN #45

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[W5][T11-2]WU PEI HSUAN #45

wants to merge 3 commits into from

Conversation

WuPeiHsuan
Copy link

No description provided.

matthiaslum
matthiaslum reviewed Feb 11, 2019
View reviewed changes
Copy link

@matthiaslum matthiaslum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow this is really quite a useful enhancement! It helps the user especially when the user forgets to capitalise people's names.

@matthiaslum
Copy link

I like how the test-case on "Betsy" shows a change in returned results.

@shawn-t
Copy link

shawn-t commented Feb 11, 2019

clean and useful enhancement! Great job! ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiaslum matthiaslum matthiaslum left review comments

@stephlewyh stephlewyh Awaiting requested review from stephlewyh

Assignees

@leerachel leerachel

Labels
team.2 tutorial.T11
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@WuPeiHsuan @matthiaslum @shawn-t @nus-se-pr-bot @leerachel