-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[W5][T08-01]-ZhaoJunRu #44
base: master
Are you sure you want to change the base?
[W5][T08-01]-ZhaoJunRu #44
Conversation
Interesting enhancement, the confirmation is widely used and very relevant to this |
Definitely a useful safeguard for newer users who accidentally type in the command |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job for adding a simple but a nice enhancement. I would suggest to always update/add the test cases as well as a practice whenever you make a functional change.
Clears all entries from the address book. + | ||
Any key to exit clear function |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good that you have updated the UserGuide
|
||
@Override | ||
public CommandResult execute() { | ||
addressBook.clear(); | ||
return new CommandResult(MESSAGE_SUCCESS); | ||
System.out.println("Confirm to clear the entire address book? YES to continue"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simple but a useful change!
No description provided.