Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[W5][T08-01]-ZhaoJunRu #44

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

quinnzzzzz
Copy link

No description provided.

@quinnzzzzz quinnzzzzz changed the title W5T0801-ZhaoJunRu Warning Message added [W5][T08-01]-ZhaoJunRu Feb 11, 2019
@ndhuu
Copy link

ndhuu commented Feb 11, 2019

Interesting enhancement, the confirmation is widely used and very relevant to this

@articstranger
Copy link

Definitely a useful safeguard for newer users who accidentally type in the command

Copy link

@RubaP RubaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job for adding a simple but a nice enhancement. I would suggest to always update/add the test cases as well as a practice whenever you make a functional change.

Clears all entries from the address book. +
Any key to exit clear function
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good that you have updated the UserGuide


@Override
public CommandResult execute() {
addressBook.clear();
return new CommandResult(MESSAGE_SUCCESS);
System.out.println("Confirm to clear the entire address book? YES to continue");
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple but a useful change!

@RubaP RubaP added the Reviewed label Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants