[W5][M11-1]Hu Yidi #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simple feature but straightforward and useful to manage memory space
warheade
reviewed
Feb 10, 2019
|
Very clean code. The feature is also pretty useful |
okkhoy
reviewed
Feb 16, 2019
There was a problem hiding this comment.
-
Try to follow the convention for github commit messages
Add TotalCommand ...vsadded a TotalCommand to output the total number of contacts in addressbook -
Always remember to update the documentation and the tests for new features added.
- Without documentation, your users will not be aware of the new command
- Without tests, you are at a risk of regressions
|
|
||
|
|
||
| /** | ||
| * Lists all persons in the address book to the user. |
There was a problem hiding this comment.
Incorrect header comment. Remember to update the comment when you change the code (this looks like a copy-paste-forgot error)
|
@huyidi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added a TotalCommand to output the total number of contacts in addressbook