[W5][T09-2]Cheah Zhi Kang #26
Conversation
|
Good feature! It is a useful and convenient function for customers. |
|
It looks good when listing all people after adding sort function. |
|
Very useful functionalities, which makes the output more ordered and organized. :) |
There was a problem hiding this comment.
You can consider abstracting your Sort command further so that it only sorts the list of persons in the Address Book but does not list them (following the Single Responsibility Principle). Overall, good job on creating a useful feature, with updates to the UG and test cases! Please read the reviews and close this PR.
| @@ -50,6 +51,7 @@ | |||
| list | |||
| add Esther Potato p/555555 e/[email protected] pa/555, epsilon street t/tubers t/starchy | |||
| list | |||
| sort | |||
There was a problem hiding this comment.
Perhaps your input for the test case should not be added in a lexicographically sorted manner? You can consider changing the order of one or more of the test inputs to verify whether your command works as expected.
Added sort command to sort all persons' full names alphabetically and display them in a list.
Able to detect correct sort command.
Credits to Marcus Phua for some of the codes in mine.