[W5][M11-1]Wang Jiannan #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 10, 2019 16:32
…add when it does not exist It might be useful in real life scenarios
huyidi
reviewed
Feb 10, 2019
|
A very good feature. I think if the example could show the before and after will be better in illustrating the usage of the function |
okkhoy
reviewed
Feb 16, 2019
There was a problem hiding this comment.
- Do take note of the coding standards and adhere to it when you write code.
- Always remember to update the documentation and tests when you add any new features.
- Without documentation, your users will not be aware of the new feature
- Without tests, you are at a risk of regressions
|
|
||
| import seedu.addressbook.common.Messages; | ||
| import seedu.addressbook.data.exception.IllegalValueException; | ||
| import seedu.addressbook.data.person.*; |
There was a problem hiding this comment.
Do not import everything using *, import only necessary classes
| */ | ||
| public class EditCommand extends Command{ | ||
| public static final String COMMAND_WORD = "edit"; | ||
| public static final String MESSAGE_USAGE = COMMAND_WORD + ": Edits a contact in the address book. " |
| + " John Doe p/98765432 e/[email protected] a/311, Clementi Ave 2, #02-25 t/friends t/owesMoney"; | ||
|
|
||
| public static final String MESSAGE_SUCCESS = "Contact is edited: %1$s"; | ||
| //public static final String MESSAGE_NONEXISTENT_PERSON = "This person does not exist in the address book"; |
There was a problem hiding this comment.
Eliminate unused code and do not retain them commented, you can always get it back from previous versions if necessary.
| try { | ||
|
|
||
| final ReadOnlyPerson target = getTargetPerson(); | ||
| System.out.println("fk"); |
There was a problem hiding this comment.
Inappropriate code! Use the debugger instead to trace the program flow!
| } catch (PersonNotFoundException pnfe) { | ||
| return new CommandResult(Messages.MESSAGE_PERSON_NOT_IN_ADDRESSBOOK); | ||
| } | ||
| catch (DuplicatePersonException dpethisisuseless){ |
There was a problem hiding this comment.
Coding standard violation here. (2 counts!, can you identify them?)
|
@warheade |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.