[Daniel Ling Zhi Yuan] iP #495
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…print it out when "display" input received
Merge remote-tracking branch 'origin/add-gradle-support'
Project has Ui class but no Gui class. Due to change in project requirement, we need to implement a Gui. Ui class is removed and Gui class created. New Gui class required for better OOP representation, to obey "has-a" relationship between BrotherBot and Gui. New loadHistory() created in BrotherBot class
Project has Ui class but no Gui class. Due to change in project requirement, we need to implement a Gui. Ui class is removed and Gui class created. New Gui class required for better OOP representation, to obey "has-a" relationship between BrotherBot and Gui. New loadHistory() created in BrotherBot class.
No checks in place to ensure validity of input filepath string. Assumption that file path is valid is not justified. Add assert feature to validate filepath. Ensure handling of error thrown in event of invalid filepath. No other additional info.
enhance code quality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.