Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[W15-1] Fashion Match #16

Open
wants to merge 687 commits into
base: master
Choose a base branch
from

Conversation

rafflesandrison
Copy link

@PhilipPhil
Copy link

👌

kthSim added a commit to cchj1995/addressbook-level4 that referenced this pull request Mar 4, 2019
Added Jia Hao's information into AboutUs.adoc
@leeyh20 leeyh20 added W15-1 and removed W15-2 labels Mar 5, 2019
@leeyh20
Copy link

leeyh20 commented Mar 12, 2019

GitHub project page

  • Please update the link and the information at the top of your GitHub page
    image

Readme Page

About Us

  • You should change or edit the first line to say that it is [name of your project] and developed by [your team name].
  • Your development responsibilities should be in this format:

Role: Team Lead / Developer
Responsibilities:
In charge of [Component]
Working on [name of feature]

You will be receiving your UG and DG comments separately.

yonggqiii pushed a commit to yonggqiii/main that referenced this pull request Mar 12, 2019
@rafflesandrison
Copy link
Author

rafflesandrison commented Mar 12, 2019

GitHub project page

  • Please update the link and the information at the top of your GitHub page
    image

Readme Page

About Us

  • You should change or edit the first line to say that it is [name of your project] and developed by [your team name].
  • Your development responsibilities should be in this format:

Role: Team Lead / Developer
Responsibilities:
In charge of [Component]
Working on [name of feature]

You will be receiving your UG and DG comments separately.

@leeyh20
Completed all the issues you have pointed out.

Except for
"The site doesn't seem to be linked correctly at https://nus-cs2103-ay1819s2.github.io/cs2103-website/admin/projectList.html . Can you make your repo name uppercase?"

Image below shows that I have changed the name of my repo to UPPERCASE.
image

@leeyh20
Copy link

leeyh20 commented Mar 12, 2019

@rafflesandrison By uppercase, I mean it should be CS2103-AY1819S2-W15-1/main

@leeyh20
Copy link

leeyh20 commented Mar 12, 2019

@rafflesandrison Remember to close your milestone ver1.1 which is overdue. Additionally, you should add a Team Lead as your Role, and also assign a Component (Logic, Model, UI, Storage etc) to each person in the group. Do refer to other groups' AboutUs page for reference.

@rafflesandrison
Copy link
Author

@rafflesandrison By uppercase, I mean it should be CS2103-AY1819S2-W15-1/main

@leeyh20
Done !

@rafflesandrison
Copy link
Author

@rafflesandrison Remember to close your milestone ver1.1 which is overdue. Additionally, you should add a Team Lead as your Role, and also assign a Component (Logic, Model, UI, Storage etc) to each person in the group. Do refer to other groups' AboutUs page for reference.

@leeyh20
Done !
Thanks for pointing them out !

@leeyh20
Copy link

leeyh20 commented Mar 14, 2019

Do also add issues to your milestones and add a proper due-date to each of the milestones. Remember to close after the milestone is over!

@stanleymok
Copy link

Alright, updated the milestones and we'll be sure to add issues as we go along.

DMGREENHOUSE pushed a commit to DMGREENHOUSE/addressbook-level4 that referenced this pull request Mar 19, 2019
User guide and Developer Guide is updated.
@EugeneYiren EugeneYiren deleted the master branch August 13, 2020 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants