Skip to content

Commit

Permalink
docs: remove DummySearchPage
Browse files Browse the repository at this point in the history
The DummySearchPage was introduced in 29b02b4 (docs: add
DummySearchPage.html, 2018-02-02). With it, additional build steps were
added to the build.gradle, .travis.yml files so that the DummySearchPage
would be copied into the build/docs/html5 directory, and would be
deployed with the rest of the documentation to
https://se-edu.github.io/addressbook-level4/DummySearchPage.html.

However, this also meant that downstream forks would also receive these
additional build steps, even though they do not need them. We only need
one single DummySearchPage to be published at one single public URL, and
thus these build steps are unnecessary for downstream forks.

We have already copied the DummySearchPage and published it at
https://se-edu.github.io/dummy-search-page/. As such, let's remove the
DummySearchPage and build steps from this codebase, so that we can
simplify our build and CI configuration.
  • Loading branch information
pyokagan committed Dec 13, 2018
1 parent 9511372 commit f7fd686
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 40 deletions.
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ matrix:

script: >-
./config/travis/run-checks.sh &&
./gradlew clean checkstyleMain checkstyleTest headless allTests coverage coveralls asciidoctor copyDummySearchPage
./gradlew clean checkstyleMain checkstyleTest headless allTests coverage coveralls asciidoctor
deploy:
skip_cleanup: true
Expand Down
5 changes: 0 additions & 5 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -231,11 +231,6 @@ task deployOfflineDocs(type: Copy) {
}
}

task copyDummySearchPage(type: Copy) {
from 'docs/DummySearchPage.html'
into "${buildDir}/docs/html5"
}

deployOfflineDocs.dependsOn asciidoctor
processResources.dependsOn deployOfflineDocs

Expand Down
32 changes: 0 additions & 32 deletions docs/DummySearchPage.html

This file was deleted.

3 changes: 1 addition & 2 deletions src/main/java/seedu/address/ui/BrowserPanel.java
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,7 @@
public class BrowserPanel extends UiPart<Region> {

public static final String DEFAULT_PAGE = "default.html";
public static final String SEARCH_PAGE_URL =
"https://se-edu.github.io/addressbook-level4/DummySearchPage.html?name=";
public static final String SEARCH_PAGE_URL = "https://se-edu.github.io/dummy-search-page/?name=";

private static final String FXML = "BrowserPanel.fxml";

Expand Down

0 comments on commit f7fd686

Please sign in to comment.