Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[W2.4b][W3.3][W09-A4] Charles Goh #12

Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

[W2.4b][W3.3][W09-A4] Charles Goh #12

wants to merge 25 commits into from

Conversation

charlesgohck
Copy link

No description provided.

Charles Goh and others added 25 commits August 23, 2017 11:32
[DS] Changed String references for person to Strings rather than inte…
d9e2984 
…gers
[PERSON][DS] Changed person from String Array to HashMap <String, Str…
3bcf337 
…ing>
[PERSON][DS] Replaced String[] person paramters with HashMap equivalent
beb1006
[PERSON][DS] Changed stray String[] person to HashMap equivalent
03d811c
[INDEX][HASH] Changed index to hash property, i.e. DATA_INDEX to PROP…
6be9c03 
…ERTY
[ALL_PERSONS] Edited ALL_PERSONS generic type to accept HashMap
c9f4935
[DEBUG] Changed DS of addedPerson and deletedPerson to accept HashMap…
4258f8f 
… param
[FIX][ARRAYLIST][HASHMAP] Changed Arraylist to contain HashMaps intea…
13901c6 
…d of String[]s
[FIX] Fixed data entry to HashMap for makePersonFromData function
35037f2
[FIX] Fixed data retrieval from HashMap in isPersonDataValid function
69516d7
[HASHMAP][GET][FIX] Changed person info getters for HashMap
78653f6
[IMPORTS] Imported all of Java Util instead of individual calls
6522a14
[FIX][DS] Replaced more ArrayList person calls with HashMap equivalent
c3c5529
[DEMO][VARARGS] Demoed non varargs showToUser version (commented out)
8d4ef1b
[REFACTOR] Reversed conditional for two functions (loadPersonsFromFil…
ae52457 
…e and decodePersonsFromStrings)
[REFACTOR] Rolled back decodePersonsFromStrings and replaced hardcode…
53d6fdd 
…d boolean statements in isPersonDataExtractableFrom
[INDENTATION] Fixed indentation for switch statement
d44f01d
[COMMAND][SORT] Set up case and static declarations for sortby command
6a2be7d
[COMMAND][SORT] Changed scope setup for sort to name asc and desc only
8772fae
[FIX][COMMAND][SORT] Fixed differing static variable
7687907
[COMMAND][SORTBYNAME] Implemented Brute Force Sort by Name command
c8e3030
[FIX] Fixed accidental deletion of conditional statement that broke r…
244667e 
…untime
[FIX][COMMAND][SORTBYNAME] Fixed wrong variable that cause CLI to crash
b2dd079
[DOCS][COMMAND][SORT] Added documentation for name sort
d678c97
[FIX][COMMAND][SORT] Fixed COMMAND_SORT_EXAMPLE constant variable
316a8f7
@nus-se-pr-bot
Copy link

nus-se-pr-bot commented Sep 8, 2017 •
edited
Loading

Hi @CharlesGoh, your pull request title is invalid.

It should be in the format of [Learning Outcome ID][Team ID] Your Name, where [Learning Outcome ID] has no dashes or spaces (e.g. [W3.1a]) and [Team ID] has one dash only and no spaces (e.g. [W14-A2] means Wednesday 2pm (14 hrs), Phase A, Team 2).

Please follow the instructions given strictly and edit your title for reprocessing.

Submit only one learning outcome per pull request (unless otherwise stated in instructions) and do remember to create your branches from the commit where the master branch is pointing at so that each PR you submit only consist of commits meant for the activity.

Note: this comment is posted by a bot. If you believe this is done in error, please create an issue at cs2103-pr-bot and add a link to this PR.

@charlesgohck charlesgohck changed the title [LO-HashMap][LO-Sort-Enhancement] Changed underlying person storage DS to HashMap and added Sort by name asc/desc command [W4.8b][W09-A4] Changed underlying person storage DS to HashMap and added Sort by name asc/desc command Sep 8, 2017
@charlesgohck charlesgohck changed the title [W4.8b][W09-A4] Changed underlying person storage DS to HashMap and added Sort by name asc/desc command [W2.4b][W09-A4] Changed underlying person storage DS to HashMap and added Sort by name asc/desc command Sep 8, 2017
@charlesgohck charlesgohck changed the title [W2.4b][W09-A4] Changed underlying person storage DS to HashMap and added Sort by name asc/desc command [W2.4b][W09-A4] [W4.8b][W09-A4] Charles Goh Sep 8, 2017
@charlesgohck charlesgohck changed the title [W2.4b][W09-A4] [W4.8b][W09-A4] Charles Goh [W2.4b][W3.3][W09-A4] Charles Goh Sep 8, 2017
@nus-se-pr-bot
Copy link

Hi @CharlesGoh, your pull request title is invalid.

It should be in the format of [Learning Outcome ID][Team ID] Your Name, where [Learning Outcome ID] has no dashes or spaces (e.g. [W3.1a]) and [Team ID] has one dash only and no spaces (e.g. [W14-A2] means Wednesday 2pm (14 hrs), Phase A, Team 2).

Please follow the instructions given strictly and edit your title for reprocessing.

Submit only one learning outcome per pull request (unless otherwise stated in instructions) and do remember to create your branches from the commit where the master branch is pointing at so that each PR you submit only consist of commits meant for the activity.

Note: this comment is posted by a bot. If you believe this is done in error, please create an issue at cs2103-pr-bot and add a link to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
FormatCheckRequested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charlesgohck @nus-se-pr-bot