Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Halo96 v2] Add numpad 5 to leds in position_mode #8

Closed
wants to merge 1 commit into from

Conversation

tsleal29
Copy link

Description

Hi NuPhy team,

I recently bought a Halo96 v2 and one of the features I was excited about was the illuminated homing keys.
Sadly the numpad 5 key does not light up as the F, J and up arrow, although on your website we can see the 5 key also beautifully lit in the pictures.

I opened this PR in hopes of fixing this issue.

I tested the updated firmware on my keyboard and everything seems to be working fine.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Test

IMG_3211

@tsleal29
Copy link
Author

@nuphy-src
It's unrelated to the issue addressed by this PR but I noticed, as mentioned here, that I have more debounce issues (unintended double taps) with the firmware from this repo than with the original firmware that came with the keyboard.

It would indeed be nice if you could update the algorithm in the repo 🙏

starryalley pushed a commit to starryalley/qmk_firmware that referenced this pull request Sep 5, 2024
@tsleal29 tsleal29 changed the title Add numpad 5 to lit leds in position_mode [Halo96 v2] Add numpad 5 to leds in position_mode Sep 9, 2024
@tsleal29 tsleal29 closed this by deleting the head repository Oct 21, 2024
@tsleal29
Copy link
Author

Closing the PR as it seems to have been fixed by @nuphy-src in their last commit.
Too bad I couldn't contribute 🥲

@nuphy-src
Copy link
Owner

Closing the PR as it seems to have been fixed by @nuphy-src in their last commit. Too bad I couldn't contribute 🥲

Thank you for your support, the issue of num has been solved, With this version of repo, can you detect double taps problems ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants