Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fix: "kb" and "user" level functions updated #6

Closed
wants to merge 1 commit into from

Conversation

Prens282
Copy link

@Prens282 Prens282 commented Jun 8, 2024

Description

Updated some function is the nuphy keyboards ansi.c files to better represent the intent of the QMK kb and user level separatíon.

Types of Changes

  • Core
  • ?Bugfix?
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • NONE*

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@Prens282 Prens282 force-pushed the small_fixes branch 2 times, most recently from b9c5a26 to 9be5f0e Compare June 10, 2024 20:39
@Prens282
Copy link
Author

qmk firmware compiles with the changes. Sadly I could not test the functionality since the latest commit from "nuphy-keyboards" branch does not work for me. It does brick the keyboard for me.

@Prens282 Prens282 closed this Jun 12, 2024
@Prens282 Prens282 deleted the small_fixes branch June 12, 2024 20:12
@Prens282 Prens282 restored the small_fixes branch June 12, 2024 20:12
@Prens282 Prens282 deleted the small_fixes branch June 20, 2024 19:09
Prens282 added a commit to Prens282/qmk that referenced this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant