Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎏 Adding arabic languag + shortcodes for ltr/rtl #975

Merged
merged 5 commits into from
Oct 5, 2023

Conversation

ajmandourah
Copy link
Contributor

Arabic was not added as a language . I have seen an old PR but for some reason was not implemented.
I added my translations that i have been using for my personal site.

Additionally, mixing ltr/rtl content is something many need especially in a blog post . I added 2 shortcodes where you can implement in the post where the content in between will be rendered as the desired direction

{{% rtl %}}
This content will be rendered as RTL
- this also
- this also
{{% /rtl %}}

@nunocoracao
Copy link
Owner

@ajmandourah thanks for this
A couple of requests:

  1. Add the two shortcodes to the documentation so that people know how to use them - please include an example
  2. Could the shortcodes leverage tailwind and the classes already created for ltr and rtl rendering - wondering if in the future we change something the Shortcodes should follow the same logic without requiring separate code fixes.

@nunocoracao nunocoracao changed the base branch from main to dev September 28, 2023 23:25
@nunocoracao nunocoracao changed the title Adding arabic languag + shortcodes for ltr/rtl 🎏 Adding arabic languag + shortcodes for ltr/rtl Sep 28, 2023
@nunocoracao nunocoracao deleted the branch nunocoracao:dev September 29, 2023 00:01
@nunocoracao nunocoracao reopened this Sep 29, 2023
@ajmandourah
Copy link
Contributor Author

  • will work on the docs this weekend.
  • makes sense regarding tailwind. Alas my experiece in it is minimal. The purpose for now of the shortcodes is when mixing contents in posts is desired. where most of the converted markdown have no css classes or ids.

@ajmandourah
Copy link
Contributor Author

Docs updated.
for the TW class, the text-aligment is probably not needed, its more of an assurance that the contents alignment will match the direction of the language. nevertheless, I included it in a TW-ready specified class.

@nunocoracao
Copy link
Owner

Thanks @ajmandourah will try to merge to dev this weekend

@nunocoracao nunocoracao merged commit 32ac1de into nunocoracao:dev Oct 5, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants