Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exclude pages with "xml" = false or "externalUrl". #1787

Conversation

fuse314
Copy link
Contributor

@fuse314 fuse314 commented Oct 10, 2024

Pages that include the "xml" = false attribute are excluded from the XML-Sitemap, but they still appeared in the RSS-feed.
Pages that include a externalUrl that starts with http:// or https:// are excluded from the XML-Sitemap, but they still appeared in the RSS-feed.

This PR implements the same filters used in sitemap.xml in the RSS-feed template.

@nunocoracao
Copy link
Owner

Sorry @fuse314 closing this one. In my case, for example, I do want external links to popup in RSS feed and exclude them from the sitemap.

@nunocoracao nunocoracao closed this Nov 8, 2024
@fuse314 fuse314 deleted the fix/exclude-xml-false-and-externalurl-from-rss-feed branch November 8, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants