Add Xing icon #1183
Closed
Add Xing icon #1183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arunoruto the svg is not well formated chake the other files for examples. You're missing the fillColor parameter for example. |
|
Sorry for the late reply, I was a bit busy.. I added the fill attribute to the xing icon. Should I make a new PR? This may be a bit out of scope, but would it be desirable to fetch the icons dynamically from simpleicons instead of providing them with the repo? It doesn't save much storage space, but it simplifies retrieving new icons. |
|
Sorry man the PR was closed because of the new release merge. Please open a new PR. Let's stick to the current solution to decrease external dependencies, easier for me to manage. Again, sorry for the closing PR thing, and thanks for helping making this better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #1111