Feature/hero-image gradient parameter #1063
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a boolean site-parameter to control the application of the
bg-gradient-to-r
darkening css on a Hero image. For backwards compatibility/'principle-of-least-astonishment', this parameter is set to 'true' by default, maintaining the previous default behavior of darkening the hero image via CSS.This also applies the Tailwind CSS 'drop-shadow-md' property to the Author and Site Title sections. This will be invisible over a dark image, but aids in readability over a light image (such as what may get displayed if homepageImageGradientOverlay is set to false).
Please don't hesitate to suggest changes if there is a cleaner/better/less-hateful way to do this - I am not the strongest when it comes to FE HTML/CSS stuff, but I am always eager to learn and improve.