Make the version3X build correctly #1407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@OsirisTerje @manfred-brands or anyone else |
veleek
reviewed
May 31, 2024
src/NUnitEngine/nunit.engine.core.tests/Services/ExtensionManagerTests.cs
Show resolved
Hide resolved
|
It turns out that the two commentsfrom @veleek about the engine and engine core .NET standard 2.0 tests is both important and non-trivial to fix if we continue to test using NUnitLite. We might need a few new projects for the .NET Standard stuff. I think I'll postpone this and create separate issues. I'll continue to wait for any more reviews before merging, however. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As with PR #1405, which applies to branch main, this PR merely does what is needed so that the branch builds correctly in CI. As part of this, all .NET Core 2.1 builds have been removed.