Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go: add GOPATH option #301

Closed
wants to merge 1 commit into from
Closed

go: add GOPATH option #301

wants to merge 1 commit into from

Conversation

WolfangAukang
Copy link
Contributor

Needed to add this option because on the workplace I have to create a separate path for my Go directory.

I am using null as default value here because as GOPATH must be an absolute path (it complains it if is relative), using $HOME/go as a default value is not a good idea.

Copy link
Member

@zimbatm zimbatm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to create issues as soon as the configuration is shared between users. A better approach would be to set env = [{ name = "GOPATH"; eval = "$HOME/go"; }].

@WolfangAukang
Copy link
Contributor Author

@zimbatm before pushing my changes and regarding your review, I believe the type for this option should be types.either types.path types.str right? If I leave it only as types.path with $HOME/go as default value, the builds for the PR will fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants