Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update theme (0.5) #694

Merged
merged 14 commits into from
Dec 1, 2023
Merged

Update theme (0.5) #694

merged 14 commits into from
Dec 1, 2023

Conversation

jarrodmillman
Copy link
Member

@jarrodmillman jarrodmillman commented Nov 14, 2023

We should do this as a merge commit (not squash and merge).

This is a major theme update to align us more with the styling and accessibility work being done on pydata-sphinx-theme.

Currently the dark theme mode is disabled. We will make a follow-up PR to enable the dark theme mode as it will involve updates to several images.

See the release notes for more details:

Copy link

netlify bot commented Nov 14, 2023

Deploy Preview for numpy-org ready!

Name Link
🔨 Latest commit 3df134f
🔍 Latest deploy log https://app.netlify.com/sites/numpy-org/deploys/6567e1438a8bfb000811f172
😎 Deploy Preview https://deploy-preview-694--numpy-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jarrodmillman jarrodmillman marked this pull request as draft November 14, 2023 20:36
@stefanv
Copy link
Contributor

stefanv commented Nov 15, 2023

  • Fix scientific domains overflow 747ca8b
  • About: Missing OpenCollective widget 95c3a55
  • Case studies: block quotes rendering incorrectly
  • Footer: sign up for mailing list box misaligned
  • Language drop down: links aren't colored 6647005
  • Copyright owner missing; add name to author field in config.yaml d07b650
  • Disable dark theme dae065e

Future PR

  • dark theme
    • Undo dae065e
    • Logos not rendering well in dark mode (scientific domains; sponsorships on About)
    • Tabs: last two tabs seem to have rendering problems; also check dark mode
      color
    • Language drop down: wrong color in dark mode (should be fixed in theme?)

@alphapapa
Copy link
Contributor

@jarrodmillman @stefanv While working on updating the "Ecosystem/Scientific Domains" tab (to use CSS flex and simplify the configuration, which was half in an HTML template and half in a YAML file), I pushed scientific-python/scientific-python-hugo-theme#413, which will allow the use of Sass files in downstream sites. That makes the CSS related to these tabs much simpler and more concise.

@alphapapa
Copy link
Contributor

Since I'm unable to push to this PR's branch, I'm pushing to my fork here: https://github.com/alphapapa/numpy.org/commits/theme-0.5

@stefanv
Copy link
Contributor

stefanv commented Nov 20, 2023

@jarrodmillman Shall we pin the latest commit on the theme and set this ready for review?

@jarrodmillman
Copy link
Member Author

I am going to make a 0.5 release first.

@jarrodmillman jarrodmillman changed the title WIP: Update theme (0.5) Update theme (0.5) Nov 30, 2023
@jarrodmillman jarrodmillman marked this pull request as ready for review December 1, 2023 14:44
Copy link
Member

@InessaPawson InessaPawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jarrodmillman This is quite a change! Let's give it a go.

@InessaPawson InessaPawson merged commit 0adbabb into numpy:main Dec 1, 2023
4 checks passed
@stefanv
Copy link
Contributor

stefanv commented Dec 3, 2023

Thanks @InessaPawson!

@alphapapa
Copy link
Contributor

Future PR

  • dark theme

    • Undo dae065e
    • Logos not rendering well in dark mode (scientific domains; sponsorships on About)
    • Tabs: last two tabs seem to have rendering problems; also check dark mode
      color
    • Language drop down: wrong color in dark mode (should be fixed in theme?)

For future reference, see #707 for these issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants