-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update theme (0.5) #694
Update theme (0.5) #694
Conversation
✅ Deploy Preview for numpy-org ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
4386b19
to
c5542be
Compare
Future PR
|
@jarrodmillman @stefanv While working on updating the "Ecosystem/Scientific Domains" tab (to use CSS flex and simplify the configuration, which was half in an HTML template and half in a YAML file), I pushed scientific-python/scientific-python-hugo-theme#413, which will allow the use of Sass files in downstream sites. That makes the CSS related to these tabs much simpler and more concise. |
c5542be
to
ea8c5e9
Compare
Since I'm unable to push to this PR's branch, I'm pushing to my fork here: https://github.com/alphapapa/numpy.org/commits/theme-0.5 |
573689a
to
fac7a34
Compare
@jarrodmillman Shall we pin the latest commit on the theme and set this ready for review? |
I am going to make a 0.5 release first. |
ef489a3
to
ff08655
Compare
ff08655
to
3df134f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jarrodmillman This is quite a change! Let's give it a go.
Thanks @InessaPawson! |
For future reference, see #707 for these issues. |
We should do this as a merge commit (not squash and merge).
This is a major theme update to align us more with the styling and accessibility work being done on pydata-sphinx-theme.
Currently the dark theme mode is disabled. We will make a follow-up PR to enable the dark theme mode as it will involve updates to several images.
See the release notes for more details: