Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CircleCI config and GitHub workflow to redirect to CircleCI #90

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

melissawm
Copy link
Member

Appropriate tokens need to be set on the repo side.

Appropriate tokens need to be set on the repo side.
Copy link
Member

@Kai-Striega Kai-Striega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, with a couple of questions. Thanks!

.circleci/config.yml Outdated Show resolved Hide resolved
Comment on lines +35 to +37
poetry install
python -m pip install sphinx pydata-sphinx-theme
cd docs; make html
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be simplified with poetry. Poetry has the concept of dependency groups meaning we can install the doc dependencies by running poetry install --with doc. I think we will be required to change the makefile to work with poetry if we do go down that route though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am trying but even with the right dependencies in the docs group of the pyproject.toml file, when I do "poetry install --with docs" nothing is installed. To be fair none of the other groups work for me either and "poetry install --with test" or "poetry install --with bench" also don't do anything. I'm really not familiar with poetry so I wonder if I'm missing a step somewhere...

Copy link
Member

@Kai-Striega Kai-Striega Dec 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The argument should be docs, not doc (note the extra s) - that's on me, I got it wrong in the above comment. It might be that you have installed all the dependencies already in your local environment, which is why it's not installing anything else.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I figured the doc vs docs thing looking at

[tool.poetry.group.docs.dependencies]

Still, it doesn't work:

➜  numpy-financial git:(setup-circle) poetry install --with docs
Installing dependencies from lock file

No dependencies to install or update

Installing the current project: numpy-financial (1.1.0.dev0)
➜  numpy-financial git:(setup-circle) cd doc
➜  doc git:(setup-circle) make html
/bin/sh: linha 1: sphinx-build: comando não encontrado  # "command not found"
make: *** [Makefile:20: html] Error 127

.github/workflows/circleci_redirect.yml Outdated Show resolved Hide resolved
@Kai-Striega Kai-Striega added documentation Improvements or additions to documentation CI labels Nov 28, 2023
@melissawm
Copy link
Member Author

Hi 👋🏻 not sure if I can do anything to push this forward? Feel free to close if this is not useful. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants