-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jean claude features #5
Draft
leonjc
wants to merge
174
commits into
master
Choose a base branch
from
jean_claude_features
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… curve (log axis), function B with sqrt transformation. Correction of bug with knot insertion and controls of extrema and inflexions.
… user interface to handle function graphs
…clearing graph content is still an issue in this version and could be improved)
…rsion with first control point clamped
…ubics with specific inactivation constraint process
…the curve relocation process under two clamped points - issues subsist when inserting knots before raising the curve degree (Bernstein polynomial decomposition is not compatible with intermediate knots of multiplicity higher than one
…nerate a json file containing the knot sequence and control polygon of the curve
…nts may be removed
…l detection and curvature extrema apparition
…sliding mechanism to improve sliding mechanism and enhance the nagivation through shape spaces (doest not take into account configs of cubics with knots)
…t to quit the curve
…a appears with only one interior to the curve
…s intermédiaires de cubiques
…termediate knots
…épart pour discussion.
…ring at an extremity and curvature extrema entering along the curve
…ppearing for the simple initial curve
…of closed B-Splines: PeriodicBSplineR1toR2withOpenKnotSequence and PeriodicBSplineR1toR2
… support error management processing. First version with knot insertion and degree increment algos. Some unit tests have been added. Further ones still required.
…f sequence extracttion algo for periodic B-Splines. Associated unit tests.
…ssociated unit tests to take into account PeriodicBSplines and generalize algorithms with knot sequences with an arbitrary multiplicity at the knot origin of the curve
…thm, findSpanBoehmAlgorithm, and unit tests to take into account multiplicities at the origin of a periodic B-Spline as well as diverse multiplicities at their intermediate knots.
…ests cases for further evaluation of the knot insertion process to check its generalization.
…nces. Update of knot insertion and degree increment for periodic B-Spline. Associated unit tests with test curve up to degree 3 for validation.
…a minimal knot sequence and maximal multiplicity at extreme knots: similar to open B-Splines of type Bézier curves. Added unit tests and corresponding insertion tests.
…ence to periodic BSpline with open knot sequence and the opposite. Addition of corresponding unit tests.
…. Unit tests validate the generic scope of the insertion algorithm. First version of the extraction algorithm for periodic B-Spline.
…ethod to transform periodic B-Spline into open B-Splines. Added corresponding unit tests.
…dation tests of the input parameters of the class methods. Some associated unit tests have been added.
…iplicityOrder and update all the unit tests of these classes as well as the curve classes
… parameters in constructors -> equivalence to constructor overloads. First step with application to constructors of AbstractIncreasingOpenKnotSequence class and derived classes. Unit tests have been updated accordingly. Changed some symbol names due to the change from degree concept used in knot sequences to maximal multiplicity order.
…. Cleaned up the classes involved. Added unit tests to validate the open knot sequences derived from simple categories of open knot sequence constrauctors.
…ly increasing open knot sequences for open and closed curves. Some code cleanup has been carried out. New unit tests have been added for increasing open knot sequences for open and closed curves.
…nstructors for strictly increasing open knot sequences for open and closed curves. New methods have been added to check the validity of knot sequences (normalized basis interval, increasing and strictly increasing conditions for knots, knot index of the knot sequence origin)
…not sequences (increasing and strictly increasing). Additional code factorization. Update of the unit tests already existing for periodic knot sequences.
…reasing knot indices. Exhaustive unit tests of knots and knot indices classes. Start introduction of warning/error messages parameterization. Carry on cleaning up code.
…eorganization of the unit test file of this class. Start sketch of constructor 'overload' of BSpline curves
…uence open curve. Knot sequence constructors set up for sequences with intermediate knots of multiplicity up to maxMultiplicity to enable C0 discontinuity. Effective use of additional knot sequence validity conditions. Preparation of some curve methods to adapt to different curve constructors.
…rve and with variants of BSpline curves constructors
…rm conversions between knot sequences rather than methods. Created a directory for named constants and started to populate it with constants related to knot sequences to solve also circular dependencies of imports.
…to avoid circular dependencies of imports in the code as well as in the unit tests. Have set up directories and files to collect and specialize the named constants, warning and error messages, in the code as well as in the unit tests.
…enCurve class. Update of the nameConstants files, errorMessages files.
… extract error messages and addition of unit tests for this class
…rve and StrictlyIncreasingOpenKnotSequenceOpenCurve. Corresponding code cleanup and modifications.
…losedCurve. Update of other classes and conversion functions. Addition of methods to check the validity of open knot sequences for closed curves.
…otSequenceClosedCurve. Some additional updates of the code for this class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #