any is a builtin, Any is a type -- use str over int #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As title
esc
changed the title
kc611
reviewed
Aug 2, 2024
| arguments: list[any] = [], | ||
| unreachable: set[str] = set(), | ||
| empty: set[str] = set(), | ||
| arguments: list[Any] = [], |
There was a problem hiding this comment.
This might be unrelated but I am not sure it's good idea to have a list as a default argument? (Since it is mutable, it's generally not recommended to do that? )
There was a problem hiding this comment.
In principle, yes. In this case the compare method treats these mutable structures as immutable, and so it's ok to define them as empty here. They are either empty or contain something, but will never be modified. It's a bit shorter than handing in None and then checking at the start of the function if the argument is None and the instantiating an empty container as a result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title