Command retry on connection lost #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is the reason to add this mechanism? The library is reconnecting itself as soon as the TCP connection is lost. Is it that the connection was lost or that the command failed to execute the first time? |
|
I will try to describe the problem I was trying to solve. I tried to connect to my MRX from two separate end points, one is the home assistant and one is the MRX iOS app. Once I connect from home assistant the TCP connection stays ok, but when I turn on the iOS app the connect the previous connect to the home assistant gets lost. If I now turn on the MRX from the home assistant I get an error since the connection is lost. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a command resend mechanism to allow on/off of the receiver in case the connection is lost