-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vapor3 #85
Open
nuclearace
wants to merge
124
commits into
development
Choose a base branch
from
vapor3
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Vapor3 #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* development: Hopefully fix DiscordGatewayPayloadData.dataFromDictionary on Swift 4.2 Linux fix linux build
Allow the project to build under Swift 5.1 by removing the version constraint.
In Swift 5.1 networking-related types (such as HTTPURLResponse) have been moved into a separate FoundationNetworking module. To maintain compatibility with older versions, a preprocessor condition is used to test whether this module is available.
Since the vapor/websocket has known issues with maintaining a persistent connection, use vapor/nio-websocket-client as a WebSocket backend.
Remove redundant 'public' modifiers for public extension functions and replace deprecated APIs.
Swift 5.1 compatibility
Fix #83. Migrate to the new Vapor WebSocketKit library.
Use #available and #if os checks to ensure that Process.run and .executableURL are available. If not, use the older methods.
Migrate to WebSocketKit
Fix libsodium import
Migrate to API and Gateway v8
Add support for interactions and new slash-command API
Using the `class` keyword for protocol inheritance is deprecated in Swift 5.4.
Replace deprecated protocol class bounds with `AnyObject`
Also refactor the type into a RawRepresentable structure.
Add support for message buttons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.