TypeScript Rollout Tier 9 - Timepicker #378
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rewrites the `Timepicker` component in the `src/components/timepicker` in TypeScript. Directly specifies the names of the other Buefy components that `Timepicker` depends on instead of indirectly specifying the `name` props of those components. Trivial changes in `Timepicker.vue`: - Adds `lang="ts"` to the `<script>` section - Wraps the entire component definition with a `defineComponent` call - Stops importing and registering the `Icon` component because it is not used Trivial changes in `index.js`: - Replaces the extension: ".js" → ".ts" - Specifies the parameter type of the `Plugin.install` method
Rewrites `src/components/timepicker/Timepicker.spec.js` in TypeScript. All changes are straightforward: - Replaces the extension: ".js" → ".ts" - Imports the spec build blocks from the `vitest` package - Appends ".vue" extension to the path to import the `Timepicker` component - Types `wrapper` with `VueWrapper` In the `src/components/timepicker/__snapshots__` folder, replaces the spec snapshot produced by Jest with the one by Vitest: - `Timepicker.spec.js` → `Timepicker.spec.ts`
`rollup.config.mjs` removes "timepicker" from `JS_COMPONENTS`.
Rewrites the documentation for `Timepicker` in the `src/pages/components/timepicker` folder in TypeScript. All the changes are straightforward. Here is a TypeScript migration tip: - Explicitly import and register components so that they are type checked. No type-checking is performed for globally registered components.
|
@wesdevpro This PR is ready for your review! |
wesdevpro
approved these changes
Jan 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues:
Proposed Changes
timepickerpackages/buefy-next/rollup.config.mjswill likely cause a conflict after merging the other PRs in this tier.