Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ordinal network frame conversion #616

Merged
merged 5 commits into from
Jan 26, 2022
Merged

Ordinal network frame conversion #616

merged 5 commits into from
Jan 26, 2022

Commits on Jan 26, 2022

  1. convert network frame to function component

    @alexeyraspopov
    alexeyraspopov committed Jan 26, 2022
    Configuration menu
    Copy the full SHA
    5388fd0 View commit details
    Browse the repository at this point in the history

  2. convert ordinal frame to function component

    @alexeyraspopov
    alexeyraspopov committed Jan 26, 2022
    Configuration menu
    Copy the full SHA
    e85e0ff View commit details
    Browse the repository at this point in the history

  3. correctly use hook cleanup

    @alexeyraspopov
    alexeyraspopov committed Jan 26, 2022
    Configuration menu
    Copy the full SHA
    0bc86c6 View commit details
    Browse the repository at this point in the history

  4. Fix default scale types for OrdinalFrame 

    OrdinalFrame's `scaleType` property takes the actual D3 function and not the scale it returns.
    @emeeks
    emeeks committed Jan 26, 2022
    Configuration menu
    Copy the full SHA
    4509169 View commit details
    Browse the repository at this point in the history

  5. Get us back to working with scaleX or scaleX()

    @emeeks
    emeeks committed Jan 26, 2022
    Configuration menu
    Copy the full SHA
    ec02017 View commit details
    Browse the repository at this point in the history