Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanded cell creation #22

Merged
merged 3 commits into from
Feb 3, 2024
Merged

Expanded cell creation #22

merged 3 commits into from
Feb 3, 2024

Conversation

rgbkrk
Copy link
Member

@rgbkrk rgbkrk commented Feb 3, 2024

This accepts updates from the Tauri backend when a cell is updated. It's a little bit circular in appearance for most cases since typically this will:

  • Change content in codemirror
  • Set local state for source
  • Submit change over to Tauri
  • Recieve update from Tauri
  • Set local state for source to that which was updated by Tauri

However for Markdown cells this immediately makes the source of truth for the rendered view come from Tauri rather than in the frontend of the app.

@rgbkrk rgbkrk merged commit c6da527 into main Feb 3, 2024
3 checks passed
@rgbkrk rgbkrk deleted the expanded-cell-creation branch February 3, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant