Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nsqadmin: fix eslint errors #1469

Merged
merged 1 commit into from
Oct 30, 2023
Merged

nsqadmin: fix eslint errors #1469

merged 1 commit into from
Oct 30, 2023
+33 −16

Conversation

dudleycarr
Copy link
Contributor

Current master branch has the following eslint errors:

SCR-20231026-sbfd

PR fixes:

  • Define globals in eslint config
  • Add missing semicolons
  • Fix line length issues
  • Rename Node to NodeModel to avoid built-in conflict
  • Added lint script to package.json
  • Remove unnecessary eslint disable rules

@dudleycarr
fix eslint errors
6d4bd5c 
* Define globals in eslint config
* Add missing semicolons
* Fix line length issues
* Rename Node to NodeModel to avoid built-in conflict
* Added lint script to package.json
@dudleycarr dudleycarr changed the title fix eslint errors nsqadmin: fix eslint errors Oct 27, 2023
mreiferson
mreiferson approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@mreiferson mreiferson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mreiferson mreiferson merged commit 5cef35c into nsqio:master Oct 30, 2023
8 checks passed
@mreiferson mreiferson mentioned this pull request Oct 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mreiferson mreiferson mreiferson approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dudleycarr @mreiferson