Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use buffered writer for Snappy compression. #362

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

philpearl
Copy link

@philpearl philpearl commented Apr 12, 2024

The non-buffered writer is now deprecated. Also the amount of compression achieved and the CPU overhead is much better when using the buffered writer.

In our testing the amount of data sent by the NSQ library with Snappy compression enabled didn't improve much at all without this fix - the data was perhaps 4/5s of the original size. With the fix it's closer to 50%

The non-buffered writer is now deprecated. Also the amount of compression achieved and the CPU overhead is much better when using the buffered writer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants