GSON lookup implementation and various improvements in Maven POM. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 25, 2014 20:00
Switched to Java7 source and target. Updated Maven POM file to refine dependencies scope. Added javadocs generation. Moved test files to src/test/java. Removed all binary files from version control. Removed all project files from version control.
|
hi @malexejev, thanks for the pull-request. Sorry it took me so long to respond. It looks good, I'm fine with mavenizing it. I'm not sure the best way to handle the json dependancy though. This introduces a hard dependency on GSON, whereas @kenshiro-o is going to introduce a Jackson implementation. I dont have much experience with maven, is there a good way to have optional dependancies? I'd like to have multiple lookup implementations and let end-users select the one for the json parser they are already using. |
Open
|
This is a much cleaner merge than the other PR, I'd vote on this one. The other PR should be refactored to multiple requests. I've updated this PR at #11. |
|
see #11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switched to Java7 source and target.
Updated Maven POM file to refine dependencies scope.
Added javadocs generation.
Moved test files to src/test/java.
Removed all binary files from version control.
Removed all project files from version control.