You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is quite a big PR, so please bear with me and let me know if you are open for changes like this.
I found that the arrangedSubviews property was not properly implemented. For starters, it was always nil. Looking for a solution, I found that the heavy reliance on self.subviews made it impossible to implement arranged subviews. I started shuffling things around and here we are...
Main improvements:
arrangedSubviews is now non-nil and should be kvo'able
removing an arranged view now does not remove the view as a subview
it should now be possible to have subviews in the OAStackView that are not managed by the stack view
All the tests pass and the example project runs fine, but I'd like to do some more testing in my own project. Let me know what you think!
- removing a view from the arranged subviews now does not remove it as
a subview (like UIStackView)
- this needed a strong separation between subviews and
arrangedSubviews, not just having arrangedSubviews be all non-hidden
subviews
- implemented the arrangedSubviews @Property, which was previously
unused
- arrangedSubviews is now KVO’able
I've discovered some bugs after I filed the PR, so it definitely deserves the [WIP] annotation. I will push additional changes, but in the meantime it would be great if you think this direction is favorable.
This looks like a change to the correct direction, working with visible views was not really the optimal solution and I wanted to move away from it. I agree with your decision with going with arranged view storage.
I am really interested in seeing where this path leads 👍
Great work!
…in the aligning axis
This prevents arranged subviews from growing outside the stack view’s
frame. This could happen if the size of the stackview was constrained
so it could not become its intrinsic size.
I just pushed some more commits to this PR. Not all of them strictly relate to the arrangedSubviews change, but I've been trying to make improvements to OAStackView while integrating it into a project at work and some changes now depend on each other. ffcde3b for example has more to do with #14 (and #14 should not be merged without it). I'll explain the additional changes:
3058581 the subviews of the stack need to shrink if the stack's size is constrained. The intrinsicContentSize based approach did not cover this. Instead, the alignment strategies now add additional constraints to make sure that the stack and subviews grow/shrink together.
ffcde3b this is needed for [WIP] Adding baseline align support #14 or else the baseline constraints will not be removed properly. I am not sure about the compiler checks for the newer NSLayoutAttributes. Let me know what you think.
fc97522 implements the UIStackView approach for baseline aligning a stack view itself. I'm not sure if this is as powerful as UIStackView, since we're probably missing some private API that will update the baseline alignment when the contents of the stack changes.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is quite a big PR, so please bear with me and let me know if you are open for changes like this.
I found that the
arrangedSubviewsproperty was not properly implemented. For starters, it was alwaysnil. Looking for a solution, I found that the heavy reliance onself.subviewsmade it impossible to implement arranged subviews. I started shuffling things around and here we are...Main improvements:
All the tests pass and the example project runs fine, but I'd like to do some more testing in my own project. Let me know what you think!