[WIP] Error handling #132
Draft
[WIP] Error handling #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: TESTING config setting isn't applying as expected
TODO: TESTING config setting isn't applying as expected
mfisher87
force-pushed
the
error-handling
branch
from
1c681c9
to
dcf8bc3
Compare
mfisher87
commented
Sep 7, 2023
docker-compose.dev.yml
Outdated
| @@ -21,7 +21,9 @@ services: | |||
| - "USAON_VTA_LOGIN_DISABLED=true" | |||
| # Use a local file DB instead of a remote one: | |||
| - "USAON_VTA_DB_SQLITE=true" | |||
| # Enable the in-browser debugger: | |||
| # Disable error handlers and allow exceptions to propagate: | |||
| - "USAON_VTA_TESTING=True" | |||
There was a problem hiding this comment.
Should probably be lower-case true for consistency
|
@rmarow this is in a good place for you to pick it up. The general behavior works but the switch to disable it for development doesn't. Looking to the future, I think we should not rely on this error page as a catch-all; we should catch errors that we expect and deliver them to users in a more user-friendly way, like flashing, so they don't get taken out of what they were doing. But some errors we won't expect until they happen, and this page can be our safety net. |
MattF-NSIDC
force-pushed
the
main
branch
10 times, most recently
from
35f3e6f
to
b8cff54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need some environment variable that can be set to disable the error-handling and allow exceptions to propagate fully so (a) we can see the traceback without going to the logs, and (b) use the browser debugger. I set that envvar up, but it doesn't work as I expected. Some investigation needs to be done there.
resolves #73