Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for error message #51

Merged
merged 4 commits into from
Oct 18, 2023
Merged

Updates for error message #51

merged 4 commits into from
Oct 18, 2023

Conversation

windnagelnsidc
Copy link
Collaborator

Hi Matt,
I'm not sure I'm totally sold on what I wrote. Specifically the part about contacting NSIDC user services since that's mentioned in the next line as well. But I don't think I can update the contact user services text because you said it was part of a java script.

@MattF-NSIDC
Copy link

MattF-NSIDC commented Oct 18, 2023

But I don't think I can update the contact user services text because you said it was part of a java script.

You can update that text, I just wanted to warn that it was not standard HTML. If you follow the existing pattern, you're safe to edit that text :)

And don't worry, if you make any mistakes, we have the human review process as well as automations to catch them :) The important thing is to communicate your intent.

Copy link

@MattF-NSIDC MattF-NSIDC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing 🚀

@MattF-NSIDC MattF-NSIDC merged commit e867eb1 into main Oct 18, 2023
@MattF-NSIDC MattF-NSIDC deleted the windnagelnsidc-patch-3 branch October 18, 2023 23:41
@MattF-NSIDC MattF-NSIDC linked an issue Oct 25, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revise catastrophic error message
3 participants