-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update leap seconds data url #1
Conversation
The other urls no longer work. The only mirror I found is behind earthdata login.
No way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but can we create a new mirror on GitHub, and then add the raw.githubcontent.whatever
URL to the list? That mirror could even be part of this repo!
This isn't a static file, so a simple copy-paste mirror could break things (in the future). |
Can we have a GitHub Action on |
🤔 perhaps so. We might need to add some code to check the validity of the file at runtime. Will add an issue to consider for the future. |
Issue here: #2 Turns out the package itself contains a static copy (and without, it seems, the code to check if the file is out-of-date for the target GPS time). This package was written with (pre)OIB data in mind, which is not getting updated/added to, so the static file would work every time. As a more generic library (which we want), this approach could fail in the future when leap seconds are added/removed. |
The other urls no longer work. The only mirror I found is behind earthdata login.