Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update leap seconds data url #1

Merged
merged 6 commits into from
Aug 12, 2024
Merged

Conversation

trey-stafford
Copy link
Contributor

The other urls no longer work. The only mirror I found is behind earthdata login.

The other urls no longer work. The only mirror I found is behind earthdata
login.
@mfisher87
Copy link
Contributor

The only mirror I found is behind earthdata login.

No way.

Copy link
Contributor

@mfisher87 mfisher87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but can we create a new mirror on GitHub, and then add the raw.githubcontent.whatever URL to the list? That mirror could even be part of this repo!

@trey-stafford
Copy link
Contributor Author

Looks good, but can we create a new mirror on GitHub, and then add the raw.githubcontent.whatever URL to the list? That mirror could even be part of this repo!

This isn't a static file, so a simple copy-paste mirror could break things (in the future).

@mfisher87
Copy link
Contributor

Can we have a GitHub Action on cron that updates our mirror?

@trey-stafford
Copy link
Contributor Author

Can we have a GitHub Action on cron that updates our mirror?

🤔 perhaps so. We might need to add some code to check the validity of the file at runtime. Will add an issue to consider for the future.

@trey-stafford trey-stafford changed the title Update leap seconds data url DRAFT: Update leap seconds data url Aug 12, 2024
@trey-stafford
Copy link
Contributor Author

Can we have a GitHub Action on cron that updates our mirror?

🤔 perhaps so. We might need to add some code to check the validity of the file at runtime. Will add an issue to consider for the future.

Issue here: #2

Turns out the package itself contains a static copy (and without, it seems, the code to check if the file is out-of-date for the target GPS time). This package was written with (pre)OIB data in mind, which is not getting updated/added to, so the static file would work every time. As a more generic library (which we want), this approach could fail in the future when leap seconds are added/removed.

@trey-stafford trey-stafford changed the title DRAFT: Update leap seconds data url Update leap seconds data url Aug 12, 2024
@trey-stafford trey-stafford merged commit 0f91769 into main Aug 12, 2024
1 check passed
@trey-stafford trey-stafford deleted the update-leap-seconds-data-url branch August 12, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants