Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return a "results" class instead of a a plain list #898

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

jhkennedy
Copy link
Collaborator

@jhkennedy jhkennedy commented Dec 14, 2024

I've closed #860 and pushed that forked-branch here so that we can more easily collaborate on this feature -- just point PRs to this branch and we'll work on finishing the feature here.

@ebolch @JessicaS11

fixes #847

Pull Request (PR) draft checklist - click to expand
  • Please review our
    contributing documentation
    before getting started.
  • Populate a descriptive title. For example, instead of "Updated README.md", use a
    title such as "Add testing details to the contributor section of the README".
    Example PRs: #763
  • Populate the body of the pull request with:
  • Update CHANGELOG.md with details about your change in a section titled
    ## Unreleased. If such a section does not exist, please create one. Follow
    Common Changelog for your additions.
    Example PRs: #763
  • Update the documentation and/or the README.md with details of changes to the
    earthaccess interface, if any. Consider new environment variables, function names,
    decorators, etc.

Click the "Ready for review" button at the bottom of the "Conversation" tab in GitHub
once these requirements are fulfilled. Don't worry if you see any test failures in
GitHub at this point!

Pull Request (PR) merge checklist - click to expand

Please do your best to complete these requirements! If you need help with any of these
requirements, you can ping the @nsidc/earthaccess-support team in a comment and we
will help you out!

  • Add unit tests for any new features.
  • Apply formatting and linting autofixes. You can add a GitHub comment in this Pull
    Request containing "pre-commit.ci autofix" to automate this.
  • Ensure all automated PR checks (seen at the bottom of the "conversation" tab) pass.
  • Get at least one approving review.

📚 Documentation preview 📚: https://earthaccess--898.org.readthedocs.build/en/898/

Copy link

github-actions bot commented Dec 14, 2024

Binder 👈 Launch a binder notebook on this branch for commit d4505ed

I will automatically update this comment whenever this PR is modified

Binder 👈 Launch a binder notebook on this branch for commit c6162ff

Binder 👈 Launch a binder notebook on this branch for commit dae6435

Binder 👈 Launch a binder notebook on this branch for commit 6c90e10

Binder 👈 Launch a binder notebook on this branch for commit b0c5cd0

Binder 👈 Launch a binder notebook on this branch for commit c02763f

Binder 👈 Launch a binder notebook on this branch for commit c794d64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants