feat(react): make vitest the default test runner since it supports ESM and different moduleResolution better #28153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit c8b87a7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
ndcunningham
approved these changes
Sep 26, 2024
xiongemi
approved these changes
Sep 26, 2024
xiongemi
force-pushed
the
feat/vitest-default
branch
from
f2c07f3
to
3706344
Compare
xiongemi
force-pushed
the
feat/vitest-default
branch
from
3706344
to
9f1003f
Compare
xiongemi
force-pushed
the
feat/vitest-default
branch
from
9f1003f
to
80ef702
Compare
xiongemi
force-pushed
the
feat/vitest-default
branch
from
80ef702
to
7c68633
Compare
xiongemi
force-pushed
the
feat/vitest-default
branch
from
7c68633
to
a1fc781
Compare
xiongemi
force-pushed
the
feat/vitest-default
branch
from
a1fc781
to
ff3cda0
Compare
xiongemi
force-pushed
the
feat/vitest-default
branch
from
ff3cda0
to
3dc21a3
Compare
…M and different moduleResolution better
xiongemi
force-pushed
the
feat/vitest-default
branch
from
3dc21a3
to
c8b87a7
Compare
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the default test runner for React/Web apps to be
vitest. It aligned better with our emphasis on modern tooling, and the lack of ESM and proper TS support (usingmoduleother thancommonjs) in Jest makes it hard to use in some workspaces.Current Behavior
Expected Behavior
Related Issue(s)
Fixes #