Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the ability to get the NX_BASE after commits with [skip-ci] type messages #138

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

eXigentCoder
Copy link

In our workflow, we use @jscutlery/semver to calculate and set the version numbers for our NPM packages in their package.json files in our NX monorepo and commit that back to the GitHub repositiory with a [skip-ci] message as follows:

image

Since the package.json files will have been changed, this causes the nx-set-shas action to always include each and every one of those NX projects in the affected command which essentially causes a loop. In the above screenshot, the user commits are in green and you can see each package gets published and tagged each time.

This change allows the user to specify if the NX_BASE should be calculated as the last SHA that contains a [skip-ci] message after the originally calculated NX_BASE

Copy link

@daltonmcphaden daltonmcphaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is something I also need. Can we get a maintainer to release this?

@yann510
Copy link

yann510 commented Mar 15, 2024

This would also benefit us @AgentEnder could we please get a review :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants