-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding the ability to get the NX_BASE after commits with [skip-ci] type messages #138
Open
eXigentCoder
wants to merge
14
commits into
nrwl:main
Choose a base branch
from
eXigentCoder:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daltonmcphaden
approved these changes
Mar 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. This is something I also need. Can we get a maintainer to release this?
This would also benefit us @AgentEnder could we please get a review :) |
…with skip-ci" This reverts commit 7361db9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our workflow, we use @jscutlery/semver to calculate and set the version numbers for our
NPM packages
in theirpackage.json
files in ourNX monorepo
and commit that back to the GitHub repositiory with a[skip-ci]
message as follows:Since the
package.json
files will have been changed, this causes thenx-set-shas
action to always include each and every one of those NX projects in theaffected
command which essentially causes a loop. In the above screenshot, the user commits are in green and you can see each package gets published and tagged each time.This change allows the user to specify if the
NX_BASE
should be calculated as the lastSHA
that contains a[skip-ci]
message after the originally calculatedNX_BASE