S34U18 support #32
Open
S34U18 support #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
So now I finally have a draft with the S34U18 support. :)
The main issue was that it seems like you are using 2 "tariffs" ( low (1), high (2) ), while my meter is just reporting the "total" (0) value. (In Sweden it seems like most operators are moving towards hourly-prices).
I was actually reading the IEC standard, and it was much clearer on the tariffs:
https://www.satec-global.com/sites/default/files/EM720-IEC-62056-21.pdf
And the P1 companion standard is actually mentioning that "support for up to sixteen tariffs should be included" (
7. Data objects).So I've been refactoring the
keys['kwh']a bit, making it easier to overview and extend. But this is of course also a breaking change.If this would not be acceptable, we could still keep the old keys (marked with a "deprecated" comment).
Another thought is if we should rename
low/hightot1/t2or similar, but that could also be done if someone is actually using more then these tariffs.Another issue was that my
ampsare actually reported as a float. I see that it looks like an int in the P1 companion standard, but using an int feels a bit rough to me. Does your meter really report this as an int?And just tell me if you want the old kwh keys re-added!
// Emil
fixes #30