feat: Shift Registers for Shift+Trigger operations #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nytamin
approved these changes
Aug 31, 2023
There was a problem hiding this comment.
Great work!
This will be a very powerful and generic addition!
One note that I have is that there should probably be some written documentation detailing the overall shiftRegister functionality, possibly along with some basic examples (what actually happens when shift+S is pressed, how a page is set up etc).
| @@ -0,0 +1,35 @@ | |||
| import { SomeFeedback } from '../feedback/feedback' | |||
|
|
|||
| export class FeedbackStore<T extends SomeFeedback> { | |||
There was a problem hiding this comment.
Question: You're not really using this class as a generic anywhere, perhaps just use SomeFeedback directly?
There was a problem hiding this comment.
Well, I'm not using it right now, but the plan was that the FeedbackStore could be used for objects enhancing the SomeFeedback interface, that's why it's generic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
You can set up actions that modify an internal, global set of "Shift Registers" in the Input Gateway. The "Shift registers" state modifies the triggers emitted from Input Gateway by prefixing the trigger string with a string describing the Shift Registers state, effectively creating a new trigger. This allows for creating "Shift + Key" operations, latching "modes", pagination and cascading menus.