-
Notifications
You must be signed in to change notification settings - Fork 3
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
5f06860
commit 88baa41
Showing
1 changed file
with
19 additions
and
24 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,60 +1,55 @@ | ||
|
|
||
| <!-- | ||
| Before you open a PR, be sure to read our Contribution guidelines: | ||
| https://nrkno.github.io/sofie-core/docs/for-developers/contribution-guidelines | ||
| --> | ||
|
|
||
| ## The contributor | ||
| ## About the Contributor | ||
| <!-- | ||
| Tell us who / which organization you are representing. | ||
| Example: This PR is contributed by NRK | ||
| Tell us who / which organization you are representing, and how the Sofie team will be able to contact you. | ||
| Example: "This pull request is posted on behalf of the NRK." | ||
| --> | ||
|
|
||
| ## Type of contribution | ||
| <!-- Pick one by marking it with an "x" --> | ||
|
|
||
| This is a | ||
| ## Type of Contribution | ||
|
|
||
| - [ ] Bug fix | ||
| - [ ] Feature | ||
| - [ ] Code improvement | ||
| - [ ] Documentation improvement | ||
| - [ ] Other (please specify) | ||
| This is a: | ||
| <!-- (pick one) --> | ||
| Bug fix / Feature / Code improvement / Documentation improvement / Other (please specify) | ||
|
|
||
|
|
||
| ## Current behavior | ||
| ## Current Behavior | ||
| <!-- | ||
| Please describe how things worked before this PR. | ||
| If it's a bug fixe: Describe the bug (what was happening?) | ||
| --> | ||
|
|
||
|
|
||
| ## New behavior | ||
| ## New Behavior | ||
| <!-- | ||
| What is the new behavior? | ||
| --> | ||
|
|
||
|
|
||
| ## Test instructions | ||
| ## Testing Instructions | ||
| <!-- | ||
| Please provide some instructions and other information for how to verify that the feature works. | ||
| Examples: | ||
| * Do a Take for a part that contains an adlib, verify that the adlib plays out. | ||
| * Open the switchboard view and toggle a route, verify that the route toggles in the GUI. | ||
| * This feature also affects "feature X", so that needs to be tested for regressions as well. | ||
| * "Do a Take for a part that contains an adlib, verify that the adlib plays out." | ||
| * "Open the Switchboard panel and toggle a route, verify that the route toggles in the GUI." | ||
| * "This feature also affects 'feature X', so that needs to be tested for regressions as well." | ||
| --> | ||
|
|
||
|
|
||
| ## Other information | ||
|
|
||
| ## Other Information | ||
| <!-- The more information you can provide, the easier the pull request will be to merge --> | ||
|
|
||
| ## Status | ||
| <!-- | ||
| Before you open the PR, make sure the items below are done. | ||
| If they're not, please open the PR as a Draft. | ||
| --> | ||
|
|
||
| - [ ] PR is ready to be reviewed | ||
| - [ ] The functionality has been tested by the author | ||
| - [ ] Relevant unit tests has been added / updated | ||
| - [ ] Relevant documentation (code comments, [system documentation](https://nrkno.github.io/sofie-core/)) has been added / updated | ||
| - [ ] PR is ready to be reviewed. | ||
| - [ ] The functionality has been tested by the author. | ||
| - [ ] Relevant unit tests has been added / updated. | ||
| - [ ] Relevant documentation (code comments, [system documentation](https://nrkno.github.io/sofie-core/)) has been added / updated. |