Improve correctness for some datatypes and add some QOL changes #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamnis
commented
Jul 20, 2023
hamnis
commented
Jul 20, 2023
hamnis
commented
Jul 20, 2023
* LocationId has all currently known locations * ProjectId has validator for id * BQDataset has validator for id * BQTableId has validator for table * Use scalacheck to uphold invariants * Add Quality of Life functions
- of is the lawful constructor - unsafeOf throws exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LocationId has all currently known locations
ProjectId has validator for id
BQDataset has validator for id
BQTableId has validator for table
Use scalacheck to uphold invariants
Add Quality of Life functions