Skip to content
This repository has been archived by the owner on May 15, 2021. It is now read-only.

Allow multiple timers in Delay and Timer #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cgm616
Copy link

@cgm616 cgm616 commented Jul 16, 2018

TIMER1 and TIMER2 can now be used for this functionality instead of just
TIMER0. This can be useful for constructing multiple Delays at once (for example, in a multi-app scenario).

TIMER1 and TIMER2 can now be used for this functionality instead of just
TIMER0.
Copy link
Collaborator

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mentions TIMER0 a couple of times although it is now generic. Also this is a breaking change so we'll need to make a big version jump after adjusting the microbit crate.

@therealprof
Copy link
Collaborator

@cgm616 ping

@cgm616
Copy link
Author

cgm616 commented Aug 18, 2018

I've been using these changes a little, and I'm not sure if they're actually advisable. I must be missing something, because I can't figure out how to actually use the Delay with any of the timers. I can't find the exact error message right now, but I can't construct a Delay and then call an actual delay method on it.

@droogmic droogmic mentioned this pull request Oct 20, 2018
8 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants