export all peripherals #132
Conversation
There was a problem hiding this comment.
I think some of these peripherals are "legacy" and are included for back-compatibility: better alternatives are available. Examples are UART (vs UARTE), TWI (vs TWIM), SPI (vs SPIM). While we should still definitely import these, it would be nice to mark this somehow (probably in the doc comment) to avoid very minor footguns.
There was a problem hiding this comment.
You might want to do the same with src/v1 just for old times' sake? Not sure how many of these peripherals are supported on the nRF51 but it would be easy to look up.
There was a problem hiding this comment.
Added the the peripherals to v1 too 👍
|
Are all of these peripherals actually usable on the microbit, i.e. connected to something electrically? |
|
@qwandor Quickly inventorying, they are. Several are internal and the rest are configurable to arbitrary GPIO pins. |
hackaugusto
force-pushed
the
hacka-add-all-peripherals-to-board
branch
2 times, most recently
from
104304c
to
4a25bd5
Compare
I'm not sure which peripherals are considered legacy, should I only add comments for the ones you mentioned? |
hackaugusto
force-pushed
the
hacka-add-all-peripherals-to-board
branch
from
4a25bd5
to
f1184c0
Compare
My motivation for this was to use the SPI. I'm not sure if the idea was not to export all peripherals just to keep the API clean (or for some other reason), so fell free to close the PR if this doesn't fit the crate's goals.