Skip to content

Commit

Permalink
[Serverless Search] Fix failing MKI tests for connectors UI (elastic#…
Browse files Browse the repository at this point in the history
…174488)

In this PR, 
* Added fix to wait for connector edit name form to disappear, before
validating connector name
* Removed `failsOnMKI` tag added for connectors FTR tests

Thus, fixing failing MKI tests for connectors UI in cloud project. 

Tested in : 
* Serverless [QA](https://console.qa.cld.elstc.co/) cloud project
following instructions from [Kibana Serverless e2e Test
Guide](https://docs.google.com/document/d/1tiax7xoDYwFXYZjRTgVKkVMjN-SQzBWk4yn1JY6Z5UY/edit?pli=1#heading=h.ece2z8p74izh)
* [Production](https://cloud.elastic.co) deployment 
* local FTR tests.
  • Loading branch information
saarikabhasi authored and nreese committed Jan 10, 2024
1 parent cb1df84 commit a63e3cb
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,12 @@ export function SvlSearchConnectorsPageProvider({ getService }: FtrProviderConte
await testSubjects.existOrFail('serverlessSearchCancelNameButton');
await testSubjects.setValue('serverlessSearchEditNameFieldText', name);
await testSubjects.click('serverlessSearchSaveNameButton');
await retry.waitForWithTimeout('edit name form to disappear', 2000, () =>
testSubjects
.missingOrFail('serverlessSearchSaveNameButton')
.then(() => true)
.catch(() => false)
);
await testSubjects.exists('serverlessSearchConnectorName');
expect(await testSubjects.getVisibleText('serverlessSearchConnectorName')).to.be(name);
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
const testSubjects = getService('testSubjects');
const browser = getService('browser');
describe('connectors', function () {
// failsOnMKI, see https://github.com/elastic/kibana/issues/173929
this.tags(['failsOnMKI']);
before(async () => {
await pageObjects.svlCommonPage.login();
await pageObjects.svlCommonNavigation.sidenav.clickLink({
Expand Down Expand Up @@ -65,7 +63,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
pageObjects.svlSearchConnectorsPage.connectorOverviewPage.expectSearchBarToExist();
});

it('searchBar and select filter connector table', async () => {
it('searchBar and select, filters connector table', async () => {
pageObjects.svlSearchConnectorsPage.connectorOverviewPage.getConnectorFromConnectorTable(
TEST_CONNECTOR_NAME
);
Expand Down

0 comments on commit a63e3cb

Please sign in to comment.